Adds methods send_msg_with_flags and recv_msg_with_flags to Socket
#147215
+14
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-author
Motivation: Existing methods send_msg and recv_msg do not expose the full capabilities of the sendmsg() and recvmsg() syscalls. Changes: Add these to methods that expose the flag argument. Rewrite send_msg and recv_msg to use the _with_flags_version
poscat0x04
force-pushed
the
send-recv-msg
branch
from
10bee3f to
9d4a777
Compare
poscat0x04
changed the title
send_msg_with_flags and recv_msg_with_flags to Socket
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
|
I don't have a strong objection to this, but I'd prefer if these were added together with code that actually used them. Otherwise there's a high risk that these functions just remain unnecessary clutter. Did you have a follow-up PR in mind? |
|
Yes, I'm writing them right now. Shall I close this? |
|
I'd say so. Keeping this change as a separate commit in that PR wouldn't hurt though 😄. |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for adding
sendmsg()/recvmsg()support to more specialized sockets (UdpSocketetc.).See also #76915